Skip to content

Conversation

@lubynets
Copy link
Contributor

  1. Added possibility to set the name of histogram as a first argument of AddH1(), AddH2(), AddProfile() and AddIntegral() functions. Existing signatures of mentioned functions are also preserved in order to have back-compatibility.
  2. Added possibility to choose whether to fill TH*F or TH*D histograms (where asterisk stands for 1 or 2) - at the compilation time via command line arguments. By default the TH*F histograms are filled, in order to fill TH*D one needs to use -DUSE_THD_HISTOGRAMS=ON cmake option.
  3. Modified the .gitignore file with adding a VSCode system directory.

@lubynets lubynets merged commit 626c81d into HeavyIonAnalysis:master Jan 13, 2025
2 of 3 checks passed
@lubynets lubynets deleted the dev branch January 13, 2025 15:20
@lubynets lubynets restored the dev branch January 17, 2025 15:33
@lubynets lubynets deleted the dev branch January 17, 2025 15:45
@lubynets
Copy link
Contributor Author

NB If two or more histograms have the same name (explicitly set by user), it turns to ROOT warning Warning in <TROOT::Append>: Replacing existing TH1: hName (Potential memory leak). If one (1) does not access these histograms by string name, but only operates with them as c++ objects and (2) saves them into different folders - nothing nasty should happen. But anyway this is worth to be avoided by restructuring the logic of procedure: at the moment of histogram creation the output file should be opened and a folder location of histogram should be defined - then ROOT will be able to distinguish them and the warning will disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant