Fix buffering of two-sidded middle cover walls#1584
Merged
nstlaurent merged 2 commits intodevfrom Apr 24, 2026
Merged
Conversation
…could previously use the incorrect array which could overwrite incorrect data or crash
… to handle two-sided middle wall rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include one sided as part of the lookup key now that two-sided middle cover walls need to render in the upper and lower portions.
Add safety checks so that the buffers don't overflow in case of changed data since the calculation happens on map start.
Don't call BufferSubData continually when a map is reloaded, just flag it to reupload at the end.