Fix code links in CONTRIBUTING_A_NEW_QUEST.md

[fxedel]

Most source code files have been moved, but the corresponding links in the documentation were not updated.

[mnalis]

Welcome @fxedel , and thanks for the offered help!

However, I think CONTRIBUTING_A_NEW_QUEST.md is taken (if not completely, then mostly) from upstream https://github.com/streetcomplete/StreetComplete project. SCEE only maintains its specific differences from StreetComplete; everything else should be submitted to StreetComplete repository. (that is done to minimize merging nightmares)

Thus, IMHO, your PR should be directed there? Would you agree?

Then, when new StreetComplete release comes out, SCEE will merge their changes and release new SCEE version too. If any SCEE-specific file paths remain incorrect after that, then of course PR for fixing those would be more then welcome here!

[fxedel]

Oh, true. I came from SCEE and this documentation page and didn't realize that the documentation and also the changed file paths origin from the main SC app.

Is there an easy way to submit my commit to the main SC repo?

[mnalis]

Is there an easy way to submit my commit to the main SC repo?

Uh, dunno. Probably easiest is:

1. copy/save existing content of your CONTRIBUTING_A_NEW_QUEST.md file
2. fork StreetComplete repo too
3. edit a CONTRIBUTING_A_NEW_QUEST.md there (creating a new branch automatically), and paste that content of yours over existing one
4. (important!) when creating a PR for StreetComplete repo look in changes tab that it contains only the changes you intended (and not, say, unrelated SCEE-specific changes)
5. edit the file to undo the changes which should not be present, and go back to step 4 until you're happy.

But I'm not sure that is would be easier than just doing that search/replaces from scratch on original StreetComplete file 🤷

[matkoniecz]

It seems that I did this changes in SC in meantime, but maybe I have missed something

[riQQ]

For reference:

• streetcomplete@9d0a012
• streetcomplete@26cddf8

[matkoniecz]

There was also second commit (have not managed to catch all in the first attempt)

[Helium314]

I'll wait for a few more SC changes (especially maplibre compose) before merging upstream, and then we can have another look at where the files are now.
(just moving everything to androidMain in faecbd7 turned out to mess a lot with automatic merging, so maybe that needs to be changed / reverted before the next upstream merge...)

[Helium314]

Looks like the main/java -> androidMain/kotlin changes are all SC and were fixed, so nothing left to do?