included a thead and tbody tag for accessibility#6
Open
seppwc wants to merge 1 commit intoHellnar:masterfrom
seppwc:master
Open
included a thead and tbody tag for accessibility#6seppwc wants to merge 1 commit intoHellnar:masterfrom seppwc:master
seppwc wants to merge 1 commit intoHellnar:masterfrom
seppwc:master
Conversation
just had a quick look and noticed you hadn't included a thead or tbody tag, these should be included in future for accessibility for screen readers, there is probably a lot which can be don't for accessibility on this, but this is the bare minimum i would suggest for tables in future.
seppwc
changed the title
Owner
|
Thanks. |
Author
|
No problem, Any extra help you need for anything with this project, I would be (and I'm sure other too!) very glad to offer a hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just had a quick look and noticed you hadn't included a thead or tbody tag, these should be included in future for accessibility for screen readers, there is probably a lot which can be done for accessibility on this, but this is the bare minimum I would suggest for tables in future.