fix(output): preserve explicit empty string fields during TSV conversion#30
Merged
HenningTimm merged 2 commits intoHenningTimm:mainfrom Mar 11, 2026
Merged
Conversation
Owner
|
Thank you! Both for the fix and the extensive documentation :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #29 a TSV conversion bug where explicit empty strings in YAML (for example
watermark: "") were treated as invalid entries.Before this change,
convertprintedInvalid entry ''and could shift subsequent fields in affected TSV rows.Root Cause
In
yml2block/output.py, explicit empty strings ("") were not handled as valid values.They fell through to the error branch instead of being written as an empty TSV cell.
Changes
value == ""as a valid empty output cell during TSV writing.tests/valid/explicit_empty_string_watermark.ymlto match existing test data conventions.Files Changed
yml2block/output.pytests/integration_tests.pytests/valid/explicit_empty_string_watermark.ymlVerification
Ran:
Result:
Additionally re-ran conversion on the reported real-world input:
Invalid entry ''messages