-
Notifications
You must be signed in to change notification settings - Fork 772
Fixed CI issues #3362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fixed CI issues #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bde8949 to
ef5ebf7
Compare
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
…C_ARMORPROPERTY. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
d32263b to
7bbad10
Compare
MrKeiKun
commented
Sep 7, 2025
| AC_CONFIG_SRCDIR([Hercules]) | ||
| AC_REVISION([m4_esyscmd_s([type git >/dev/null 2>&1 && git describe --always 2>/dev/null || echo '(unknown version)'])]) | ||
| AC_PREREQ([2.71]) | ||
| AC_PREREQ([2.69]) |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MishimaHaruna @4144 i lower down the version to 2.69 since ubuntu 20.04 official repo doesnt have autoconf version 2.71 or higher
8a7abca to
ef10620
Compare
Contributor
Author
|
@4144 pcre and pcre2 are wayyyyy different. LOL |
ef10620 to
85d56e6
Compare
7ae309c to
99519dd
Compare
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
d69c181 to
ecfa319
Compare
…er sizes. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
8bd8efa to
8768774
Compare
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
8768774 to
b0e731e
Compare
Contributor
Author
|
imma split this quite big already. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed: