Sqlite store: create with pool, use acquire instead of mutex#75
Merged
beeinger merged 2 commits intoHerodotusDev:developfrom Oct 2, 2025
Merged
Sqlite store: create with pool, use acquire instead of mutex#75beeinger merged 2 commits intoHerodotusDev:developfrom
beeinger merged 2 commits intoHerodotusDev:developfrom
Conversation
1863bfd to
18735be
Compare
18735be to
e99b5b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool has its own thread-safety mechanism implemented, which we can reuse.
It's particularly useful when creating multiple concurrent read-only connections (now possible with the new
with_poolconstructor).Note the
atomic_set_many— this is a backward compatibility flag to ensure the same behaviour.