Merged
Conversation
because we only need to pass the URLSearchParams
smatthies
reviewed
Nov 27, 2024
| submit(formRef.current, { replace: true, preventScrollReset: true }); | ||
| // not the best solution as the tags now will timeout for 300ms as well - but with the onchange on the form I could not find another way | ||
| // to debounce the search input to not sent a request for each input .. happy for suggestions | ||
| clearTimeout(timeout) |
Collaborator
There was a problem hiding this comment.
@HerrBertling Any thought about this? I did want to reuse the existing filtering through the url and implemented the searchbar the same way. But since we update on each change, the search was happening for each of the character inputs. To not introduce any new things there and also not introduce additional overhead I went with a quite pragmatic approach of debouncing the input for 300ms
Co-authored-by: Francine Melo Pêpe <franmelopepe2@gmail.com> Co-authored-by: teletubbiepuddingmaschine@gmx.de <teletubbiepuddingmaschine@gmx.de>
HerrBertling
approved these changes
Dec 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
searchbar without functionality