Resolves conflicts between your fork and current pdfmake master (0.3.0-beta.2)#1
Open
samc36 wants to merge 18 commits intoHeston1:masterfrom
Open
Resolves conflicts between your fork and current pdfmake master (0.3.0-beta.2)#1samc36 wants to merge 18 commits intoHeston1:masterfrom
samc36 wants to merge 18 commits intoHeston1:masterfrom
Conversation
* attachments embedding bpampuch#956 * attachments embedding bpampuch#956 * reformat * Update CHANGELOG.md Co-authored-by: Steffen Matheis <steffen.matheis@robot5.de>
Fixes typo in README.md
|
+1 Would love to see this getting merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Heston,
I've forked your repo and pulled in master from pdfmake which should resolve the issues preventing your PR from being merged as discussed here: bpampuch#2373
Please let me know if you need anything, it would be great to get this merged into pdfmake to use acroforms.