Fix for floating point crashes and warnings for gcc 12#17
Open
JaimeRoelandts wants to merge 4 commits intoHewlettPackard:masterfrom
Open
Fix for floating point crashes and warnings for gcc 12#17JaimeRoelandts wants to merge 4 commits intoHewlettPackard:masterfrom
JaimeRoelandts wants to merge 4 commits intoHewlettPackard:masterfrom
Conversation
JaimeRoelandts
commented
Jul 20, 2023
JaimeRoelandts
commented
- Added explicit type casting to avoid int division, thus losing precision. This fixes floating point arithmetic crashes.
- Commented out unused variables
- Added spaces between a quote and the Macro
- Added brackets for conditions, because of the && to || precedence, the conditions were probably incorrect.
Fix typo in output of extio (IO Voltage Margin)
variables for gcc 12
correct. (Marking anyway for the compiler warnings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.