Fix floating-point exception in DRAM config files#23
Open
geraldofojunior wants to merge 16 commits intoHewlettPackard:masterfrom
Open
Fix floating-point exception in DRAM config files#23geraldofojunior wants to merge 16 commits intoHewlettPackard:masterfrom
geraldofojunior wants to merge 16 commits intoHewlettPackard:masterfrom
Conversation
Output CACTI IO metrics
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The InputParameter constructor left all IO-related fields uninitialized (defaulting to 0), causing division by zero in IOTechParam when config files omit the external IO parameters section. Initialize mem_data_width, num_clk, bus_freq, and all other IO fields to safe defaults. Fixes HewlettPackard#10 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2DDRAM_Samsung2GbDDR2.cfg,2DDRAM_micron1Gb.cfg,3DDRAM_Samsung3D8Gb_extened.cfg,dram.cfg) that caused aSIGFPE(division by zero) inIOTechParamconstructor due to uninitialized fields likemem_data_widthandnum_clkTest plan
./cacti -infile 2DDRAM_Samsung2GbDDR2.cfgand verify no floating-point exception./cacti -infile 2DDRAM_micron1Gb.cfgand verify no crash./cacti -infile 3DDRAM_Samsung3D8Gb_extened.cfgand verify no crash./cacti -infile dram.cfgand verify no crash./cacti -infile cache.cfgto verify no regressionFixes #10
🤖 Generated with Claude Code