tests: full white-box coverage for all public interfaces + fix process_table_destroy double-destroy segfault by Copilot · Pull Request #54 · HiGarfield/cpulimit

Copilot · 2026-02-20T23:32:49Z

Explore all .h/.c files, build and run existing 71-test suite
Bug fix in process_table.c: process_table_destroy now zeros pt->hashsize
Makefile fix: include cli.c in test build
Add 29 new tests (71 → 100) across all modules
Fix: replace non-ASCII en-dash – with ASCII hyphen - in all 9 section header comments
Fix: wrap it.dip == NULL assertion in #if defined(__linux__) for portability
Build gcc + clang CHECK=1 — zero warnings/errors
100 tests ALL PASSED

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

…li.c fix Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

…ouble-destroy segfault Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

Copilot

Pull request overview

Improves robustness and confidence in cpulimit by fixing a process_table_destroy double-destroy segfault and expanding the C unit test suite to cover previously untested branches (including parse_arguments by linking cli.c into the test binary).

Changes:

Fix process_table_destroy to clear hashsize after freeing the bucket array, preventing a second destroy from dereferencing a NULL table.
Update the test build to link src/cli.c, enabling parse_arguments tests.
Add extensive white-box tests across modules to increase branch/boundary/error-path coverage.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File	Description
`src/process_table.c`	Prevents double-destroy segfault by zeroing `hashsize` after teardown.
`tests/Makefile`	Links `cli.c` into `cpulimit_test` so CLI parsing is testable.
`tests/cpulimit_test.c`	Adds many new white-box tests, including CLI parsing and edge/error paths.

Copilot · 2026-02-21T00:46:23Z

tests/cpulimit_test.c

+}
+
+/***************************************************************************
+ * LIST MODULE – ADDITIONAL COVERAGE


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments, which can also break builds depending on compiler/locale. Replace it with an ASCII hyphen (-).

Suggested change

* LIST MODULE – ADDITIONAL COVERAGE

* LIST MODULE - ADDITIONAL COVERAGE

Fixed in 621e2f1 — replaced all 9 en-dash – characters with ASCII hyphens - in the section header comments.

Copilot · 2026-02-21T00:46:23Z

tests/cpulimit_test.c

+}
+
+/***************************************************************************
+ * UTIL MODULE – ADDITIONAL COVERAGE


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

Suggested change

* UTIL MODULE – ADDITIONAL COVERAGE

* UTIL MODULE - ADDITIONAL COVERAGE

Copilot · 2026-02-21T00:46:23Z

tests/cpulimit_test.c

+}
+
+/***************************************************************************
+ * PROCESS_TABLE MODULE – ADDITIONAL COVERAGE


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

Suggested change

* PROCESS_TABLE MODULE – ADDITIONAL COVERAGE

* PROCESS_TABLE MODULE - ADDITIONAL COVERAGE

Copilot · 2026-02-21T00:46:24Z

tests/cpulimit_test.c

+}
+
+/***************************************************************************
+ * SIGNAL_HANDLER MODULE – ADDITIONAL COVERAGE


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

Suggested change

* SIGNAL_HANDLER MODULE – ADDITIONAL COVERAGE

* SIGNAL_HANDLER MODULE - ADDITIONAL COVERAGE

Copilot · 2026-02-21T00:46:24Z

tests/cpulimit_test.c

+}
+
+/***************************************************************************
+ * PROCESS_GROUP MODULE – ADDITIONAL COVERAGE


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

Suggested change

* PROCESS_GROUP MODULE – ADDITIONAL COVERAGE

* PROCESS_GROUP MODULE - ADDITIONAL COVERAGE

Copilot · 2026-02-21T00:46:24Z

tests/cpulimit_test.c

+}
+
+/***************************************************************************
+ * LIMIT_PROCESS MODULE – ADDITIONAL COVERAGE


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

Suggested change

* LIMIT_PROCESS MODULE – ADDITIONAL COVERAGE

* LIMIT_PROCESS MODULE - ADDITIONAL COVERAGE

Copilot · 2026-02-21T00:46:24Z

tests/cpulimit_test.c

+    assert(init_process_iterator(&it, &filter) == 0);
+    /* dip is NULL because single-PID optimisation skips opendir() */
+    assert(it.dip == NULL);


test_process_iterator_close_null_dip reaches into struct process_iterator internals (it.dip). That field only exists on Linux (process_iterator.h uses #if defined(__linux__)), so this test will not compile on FreeBSD/macOS. Prefer asserting only on public behavior (e.g., close_process_iterator(&it) == 0) or wrap the it.dip assertion in #if defined(__linux__).

Suggested change

assert(init_process_iterator(&it, &filter) == 0);

/* dip is NULL because single-PID optimisation skips opendir() */

assert(it.dip == NULL);

assert(init_process_iterator(&it, &filter) == 0);

#if defined(__linux__)

/* dip is NULL because single-PID optimisation skips opendir() */

assert(it.dip == NULL);

#endif

Fixed in 621e2f1 — the it.dip assertion is now guarded with #if defined(__linux__) so the test compiles cleanly on FreeBSD and macOS.

Copilot · 2026-02-21T00:46:24Z

tests/cpulimit_test.c

+}
+
+/***************************************************************************
+ * PROCESS_ITERATOR MODULE – ADDITIONAL COVERAGE


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

Suggested change

* PROCESS_ITERATOR MODULE – ADDITIONAL COVERAGE

* PROCESS_ITERATOR MODULE - ADDITIONAL COVERAGE

Copilot · 2026-02-21T00:46:25Z

tests/cpulimit_test.c

+/***************************************************************************
+ * LIMITER MODULE – ADDITIONAL COVERAGE
+ ***************************************************************************/


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

Copilot · 2026-02-21T00:46:25Z

tests/cpulimit_test.c

+/***************************************************************************
+ * CLI MODULE – ADDITIONAL COVERAGE
+ ***************************************************************************/


This comment header uses a non-ASCII en dash ("–"). AGENTS.md requires ASCII-only source/comments. Replace it with an ASCII hyphen (-).

HiGarfield · 2026-02-21T00:47:30Z

@copilot apply changes based on the comments in this thread

…x ifdef Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

cpulimit/tests/cpulimit_test.c

Line 1931 in 621e2f1

/* Process not found with lazy_mode=1 → EXIT_FAILURE */

Replace non-ASCII comment text with ASCII-only text

/workspace/cpulimit/AGENTS.md requires that only ASCII characters appear in code/comments, but this change introduces Unicode arrow characters (→) in tests/cpulimit_test.c comments (including this line and other newly added comments). This violates the project’s documented standards and can break tooling or checks that enforce source encoding/character-set constraints, so these comment markers should be replaced with ASCII equivalents (for example, ->).

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Initial plan

e78f3a5

Copilot AI assigned Copilot and HiGarfield Feb 20, 2026

Copilot started work on behalf of HiGarfield February 20, 2026 23:33 View session

Expand unit tests: full white-box coverage + fix freopen→close

e1dc4db

Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Improve unit test coverage and revert output redirection~~ tests: full white-box coverage + fix stdout suppression (freopen → close) Feb 20, 2026

Copilot AI requested a review from HiGarfield February 20, 2026 23:45

Copilot finished work on behalf of HiGarfield February 20, 2026 23:45

Copilot started work on behalf of HiGarfield February 20, 2026 23:51 View session

tests: full white-box coverage for all public interfaces + Makefile c…

bce0a19

…li.c fix Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

Copilot AI changed the title ~~tests: full white-box coverage + fix stdout suppression (freopen → close)~~ tests: full white-box coverage for all public interfaces + fix Makefile to link cli.c Feb 21, 2026

Copilot finished work on behalf of HiGarfield February 21, 2026 00:12

Copilot started work on behalf of HiGarfield February 21, 2026 00:14 View session

tests: 100-test full white-box coverage + fix process_table_destroy d…

78d7113

…ouble-destroy segfault Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

Copilot AI changed the title ~~tests: full white-box coverage for all public interfaces + fix Makefile to link cli.c~~ tests: full white-box coverage for all public interfaces + fix process_table_destroy double-destroy segfault Feb 21, 2026

Copilot finished work on behalf of HiGarfield February 21, 2026 00:26

HiGarfield marked this pull request as ready for review February 21, 2026 00:38

Copilot AI review requested due to automatic review settings February 21, 2026 00:38

Copilot started reviewing on behalf of HiGarfield February 21, 2026 00:39 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Copilot started work on behalf of HiGarfield February 21, 2026 00:47 View session

fix: replace non-ASCII en-dashes with hyphens; guard it.dip with linu…

621e2f1

…x ifdef Co-authored-by: HiGarfield <32226909+HiGarfield@users.noreply.github.com>

Copilot finished work on behalf of HiGarfield February 21, 2026 00:50

HiGarfield approved these changes Feb 21, 2026

View reviewed changes

HiGarfield merged commit 02c3608 into master Feb 21, 2026

HiGarfield deleted the copilot/refactor-cpulimit-test-coverage branch February 21, 2026 00:51

chatgpt-codex-connector bot reviewed Feb 21, 2026

View reviewed changes

	* LIST MODULE – ADDITIONAL COVERAGE
	* LIST MODULE - ADDITIONAL COVERAGE

	* UTIL MODULE – ADDITIONAL COVERAGE
	* UTIL MODULE - ADDITIONAL COVERAGE

	* PROCESS_TABLE MODULE – ADDITIONAL COVERAGE
	* PROCESS_TABLE MODULE - ADDITIONAL COVERAGE

	* SIGNAL_HANDLER MODULE – ADDITIONAL COVERAGE
	* SIGNAL_HANDLER MODULE - ADDITIONAL COVERAGE

	* PROCESS_GROUP MODULE – ADDITIONAL COVERAGE
	* PROCESS_GROUP MODULE - ADDITIONAL COVERAGE

	* LIMIT_PROCESS MODULE – ADDITIONAL COVERAGE
	* LIMIT_PROCESS MODULE - ADDITIONAL COVERAGE

	* PROCESS_ITERATOR MODULE – ADDITIONAL COVERAGE
	* PROCESS_ITERATOR MODULE - ADDITIONAL COVERAGE

Comments

Conversation

Copilot AI commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

HiGarfield commented Feb 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 20, 2026 •

edited

Loading