Fix hex encoding a byte string #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old code lead to: AttributeError: 'bytes' object has no attribute 'encode'.
davidfokkema
approved these changes
Apr 16, 2025
Member
davidfokkema
left a comment
davidfokkema
left a comment
There was a problem hiding this comment.
Is this a string -> bytes Python 2 -> 3 leftover? Or did this change in a 3.x release? I can't really find when this changed. Good catch!
Member
Author
|
I didn't 'catch' this :) I found this because Ricardo tried to submit a new layout, which caused an error to be reported to Sentry. |
Member
Ah, good that you've set up Sentry then! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code lead to:
AttributeError: 'bytes' object has no attribute 'encode'.