Began working on adding DIR futures#138
Merged
marcoSanti merged 13 commits intocapio-v2from Jun 11, 2025
Merged
Conversation
added 12 commits
June 4, 2025 12:03
Added patches to dirent.h defined functions
Now readdir works. I need to return NULL as soon as the directory is committed. Ask for committmenet on directory from capio server
This commit changes the behaviour of posix component and server component of listdir. When called, it no longer directly asks if a file is committed, but asks for the commit token path. It then caches it, and periodically checks if said token exists. as soon as it does, it returns NULL, as specified by the POSIX semantic for listdir||()
added missing errno, and fixed return value when doing directory streaming
marcoSanti
force-pushed
the
directory-streaming
branch
from
741cfdb to
571c77b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## capio-v2 #138 +/- ##
============================================
- Coverage 51.50% 48.71% -2.80%
============================================
Files 71 73 +2
Lines 3652 3929 +277
Branches 2111 2264 +153
============================================
+ Hits 1881 1914 +33
- Misses 844 977 +133
- Partials 927 1038 +111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcoSanti
pushed a commit
that referenced
this pull request
Jun 22, 2025
This commit adds the feature to stream the content of directories, by providing streaming options when issuing a posix readdir() method call. It returns a new dirent entry as long as the directory itself is not committed. - Added patches to dirent.h defined functions - Fixed readdir. add commit return Now readdir works. I need to return NULL as soon as the directory is committed. Ask for committmenet on directory from capio server - This commit changes the behaviour of posix component and server component of listdir. When called, it no longer directly asks if a file is committed, but asks for the commit token path. It then caches it, and periodically checks if said token exists. as soon as it does, it returns NULL, as specified by the POSIX semantic for listdir||() - added missing errno, and fixed return value when doing directory streaming
marcoSanti
pushed a commit
that referenced
this pull request
Jun 22, 2025
This commit adds the feature to stream the content of directories, by providing streaming options when issuing a posix readdir() method call. It returns a new dirent entry as long as the directory itself is not committed. - Added patches to dirent.h defined functions - Fixed readdir. add commit return Now readdir works. I need to return NULL as soon as the directory is committed. Ask for committmenet on directory from capio server - This commit changes the behaviour of posix component and server component of listdir. When called, it no longer directly asks if a file is committed, but asks for the commit token path. It then caches it, and periodically checks if said token exists. as soon as it does, it returns NULL, as specified by the POSIX semantic for listdir||() - added missing errno, and fixed return value when doing directory streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the capability of performing streaming on contents of directory when the readdir and readdir64 glibc methods are invoked. Contrary to other POSIX handlers, here we patch directly methods from the glibc instead of system calls, trough the linux loader