Skip to content

Split declaration and implementation of CapioFile class#211

Merged
GlassOfWhiskey merged 15 commits intomasterfrom
capio-file-refactor
Mar 23, 2026
Merged

Split declaration and implementation of CapioFile class#211
GlassOfWhiskey merged 15 commits intomasterfrom
capio-file-refactor

Conversation

@marcoSanti
Copy link
Copy Markdown
Member

@marcoSanti marcoSanti commented Mar 4, 2026

This commit refactors the CapioFile class. In particular:

  • Splits class declaration and class implementation;
  • Resolves a bug in CapioFile::waitForData method, for which the condition variable predicate condition was reversed. It also introduces tests to check for this specific issue on both CapioFile::waitForData and CapioFile::waitForCommit;
  • Introduces several new tests on the CapioFile class to improve coverage and protect against regressions;
  • Fixes an issue in the CI/CD for which coverage was computed on the test files as well. Now they are excluded ensuring that coverage reflects only the state of the project runtime targets.

@marcoSanti marcoSanti marked this pull request as draft March 4, 2026 14:03
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 93.62745% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.59%. Comparing base (6c2814b) to head (0b0e8e0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
capio/server/src/capio_file.cpp 93.59% 0 Missing and 13 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   62.50%   64.59%   +2.09%     
==========================================
  Files          76       73       -3     
  Lines        3334     3161     -173     
  Branches     2059     1965      -94     
==========================================
- Hits         2084     2042      -42     
+ Misses        959      372     -587     
- Partials      291      747     +456     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcoSanti marcoSanti force-pushed the capio-file-refactor branch 5 times, most recently from d530119 to ce3c845 Compare March 5, 2026 15:25
@marcoSanti marcoSanti marked this pull request as ready for review March 5, 2026 15:33
@marcoSanti marcoSanti force-pushed the capio-file-refactor branch 6 times, most recently from 52530e2 to 480b1a8 Compare March 14, 2026 09:17
@marcoSanti marcoSanti force-pushed the capio-file-refactor branch from 480b1a8 to 3bc23e5 Compare March 14, 2026 09:18
@marcoSanti marcoSanti force-pushed the capio-file-refactor branch from 6f2ca34 to 1990160 Compare March 19, 2026 11:39
@marcoSanti marcoSanti force-pushed the capio-file-refactor branch 2 times, most recently from 16f2f21 to 59966ef Compare March 19, 2026 12:04
@marcoSanti marcoSanti force-pushed the capio-file-refactor branch from 59966ef to 5883993 Compare March 19, 2026 12:11
@marcoSanti marcoSanti force-pushed the capio-file-refactor branch from 5db5974 to 0b0e8e0 Compare March 19, 2026 13:04
Copy link
Copy Markdown
Collaborator

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlassOfWhiskey GlassOfWhiskey changed the title Split declaration and implementation of CapioFile class Split declaration and implementation of CapioFile class Mar 23, 2026
@GlassOfWhiskey GlassOfWhiskey merged commit 1e8b2ef into master Mar 23, 2026
46 of 80 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the capio-file-refactor branch March 23, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants