Split declaration and implementation of CapioFile class#211
Merged
GlassOfWhiskey merged 15 commits intomasterfrom Mar 23, 2026
Merged
Split declaration and implementation of CapioFile class#211GlassOfWhiskey merged 15 commits intomasterfrom
CapioFile class#211GlassOfWhiskey merged 15 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 62.50% 64.59% +2.09%
==========================================
Files 76 73 -3
Lines 3334 3161 -173
Branches 2059 1965 -94
==========================================
- Hits 2084 2042 -42
+ Misses 959 372 -587
- Partials 291 747 +456 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d530119 to
ce3c845
Compare
marcoSanti
commented
Mar 5, 2026
marcoSanti
commented
Mar 5, 2026
52530e2 to
480b1a8
Compare
480b1a8 to
3bc23e5
Compare
added 10 commits
March 18, 2026 22:57
6f2ca34 to
1990160
Compare
16f2f21 to
59966ef
Compare
59966ef to
5883993
Compare
5db5974 to
0b0e8e0
Compare
CapioFile class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
CapioFileclass. In particular:CapioFile::waitForDatamethod, for which the condition variable predicate condition was reversed. It also introduces tests to check for this specific issue on bothCapioFile::waitForDataandCapioFile::waitForCommit;CapioFileclass to improve coverage and protect against regressions;