Skip to content

Refactor naming scheme of class CapioFile#212

Merged
GlassOfWhiskey merged 1 commit intomasterfrom
capio-file-refactor-1
Mar 11, 2026
Merged

Refactor naming scheme of class CapioFile#212
GlassOfWhiskey merged 1 commit intomasterfrom
capio-file-refactor-1

Conversation

@marcoSanti
Copy link
Copy Markdown
Member

@marcoSanti marcoSanti commented Mar 11, 2026

This pull request refactors the CapioFile class, moving it within the context of the server/storage. It also refactor the names of the methods to better align with the names of the other refactored CAPIO classes. Finally it removes inline specifiers from the function methods as they are ineffective.

@marcoSanti marcoSanti force-pushed the capio-file-refactor-1 branch 2 times, most recently from 2b5a719 to e196ffb Compare March 11, 2026 20:30
@marcoSanti marcoSanti force-pushed the capio-file-refactor-1 branch from e196ffb to 2983925 Compare March 11, 2026 20:38
Copy link
Copy Markdown
Collaborator

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 51.65563% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.49%. Comparing base (7b58291) to head (2983925).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
capio/server/include/remote/handlers/read.hpp 0.00% 1 Missing and 16 partials ⚠️
capio/server/include/handlers/read.hpp 20.00% 3 Missing and 9 partials ⚠️
capio/server/include/storage/capio_file.hpp 75.00% 7 Missing and 5 partials ⚠️
capio/tests/unit/server/src/storage_manager.cpp 0.00% 0 Missing and 7 partials ⚠️
capio/server/include/handlers/getdents.hpp 0.00% 1 Missing and 5 partials ⚠️
capio/server/include/handlers/stat.hpp 28.57% 0 Missing and 5 partials ⚠️
capio/server/include/remote/handlers/stat.hpp 0.00% 1 Missing and 3 partials ⚠️
capio/server/include/utils/common.hpp 40.00% 0 Missing and 3 partials ⚠️
capio/server/include/handlers/close.hpp 0.00% 1 Missing and 1 partial ⚠️
capio/server/include/handlers/seek.hpp 0.00% 0 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   62.43%   62.49%   +0.06%     
==========================================
  Files          76       76              
  Lines        3322     3317       -5     
  Branches     2048     2046       -2     
==========================================
- Hits         2074     2073       -1     
+ Misses        436      434       -2     
+ Partials      812      810       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GlassOfWhiskey GlassOfWhiskey merged commit 54108b4 into master Mar 11, 2026
94 of 120 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the capio-file-refactor-1 branch March 11, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants