Skip to content

Privatize CapioFile public class attributes#213

Merged
GlassOfWhiskey merged 4 commits intomasterfrom
capio-file-refactor-2
Mar 13, 2026
Merged

Privatize CapioFile public class attributes#213
GlassOfWhiskey merged 4 commits intomasterfrom
capio-file-refactor-2

Conversation

@marcoSanti
Copy link
Copy Markdown
Member

@marcoSanti marcoSanti commented Mar 11, 2026

This commit further refactors methods in the CapioFile class to better reflect the logic that they implement. It also moves public CapioFile attributes to private scope, exposing getter and setters for such attributes.

@marcoSanti marcoSanti force-pushed the capio-file-refactor-2 branch from 472bb76 to ddbb4eb Compare March 11, 2026 22:31
@marcoSanti marcoSanti changed the title Refactor methods Privatize CapioFile public class attributes Mar 11, 2026
@marcoSanti marcoSanti force-pushed the capio-file-refactor-2 branch from 0e7f544 to 1607ce5 Compare March 12, 2026 09:32
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 42.72727% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.50%. Comparing base (54108b4) to head (e87e8f8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
capio/server/include/storage/capio_file.hpp 52.72% 13 Missing and 13 partials ⚠️
capio/server/include/remote/handlers/read.hpp 0.00% 1 Missing and 7 partials ⚠️
capio/server/include/handlers/read.hpp 12.50% 2 Missing and 5 partials ⚠️
capio/server/include/handlers/getdents.hpp 0.00% 1 Missing and 3 partials ⚠️
capio/server/include/handlers/stat.hpp 20.00% 0 Missing and 4 partials ⚠️
capio/server/include/remote/handlers/stat.hpp 0.00% 1 Missing and 2 partials ⚠️
capio/server/include/handlers/close.hpp 0.00% 0 Missing and 2 partials ⚠️
capio/server/include/handlers/write.hpp 50.00% 0 Missing and 2 partials ⚠️
capio/server/src/storage_manager.cpp 80.00% 0 Missing and 2 partials ⚠️
capio/tests/unit/server/src/storage_manager.cpp 0.00% 0 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   62.49%   62.50%   +0.01%     
==========================================
  Files          76       76              
  Lines        3317     3334      +17     
  Branches     2046     2059      +13     
==========================================
+ Hits         2073     2084      +11     
+ Misses        954      435     -519     
- Partials      290      815     +525     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlassOfWhiskey GlassOfWhiskey merged commit 6c2814b into master Mar 13, 2026
65 of 80 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the capio-file-refactor-2 branch March 13, 2026 17:37
@GlassOfWhiskey GlassOfWhiskey changed the title Privatize CapioFile public class attributes Privatize CapioFile public class attributes Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants