Skip to content

Improved compatibility with non x86_64 arch#215

Merged
GlassOfWhiskey merged 3 commits intomasterfrom
compatibility-fix
Mar 15, 2026
Merged

Improved compatibility with non x86_64 arch#215
GlassOfWhiskey merged 3 commits intomasterfrom
compatibility-fix

Conversation

@marcoSanti
Copy link
Copy Markdown
Member

@marcoSanti marcoSanti commented Mar 12, 2026

This commit refines the syscall lookup table generation for the CAPIO logger by replacing static parsing of unistd.h with a dynamic preprocessor-based discovery method.

Rather than scanning for x86-only headers like unistd_64.h, the updated script utilizes the CMAKE-provided compiler to resolve the standard asm/unistd.h entry point, ensuring compatibility with ARM and RISC-V based architectures.

@marcoSanti marcoSanti marked this pull request as draft March 12, 2026 12:19
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.50%. Comparing base (54108b4) to head (a4f237a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   62.49%   62.50%   +0.01%     
==========================================
  Files          76       76              
  Lines        3317     3334      +17     
  Branches     2046     2059      +13     
==========================================
+ Hits         2073     2084      +11     
- Misses        954      959       +5     
- Partials      290      291       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcoSanti marcoSanti marked this pull request as ready for review March 12, 2026 12:37
Comment thread scripts/gen_syscallnames.sh Outdated
Co-authored-by: Iacopo Colonnelli <iacopo.c92@gmail.com>
@marcoSanti marcoSanti changed the title Improved compativility with non X86 arch Improved compativility with non x86_64 arch Mar 14, 2026
@marcoSanti marcoSanti changed the title Improved compativility with non x86_64 arch Improved compatibility with non x86_64 arch Mar 14, 2026
Copy link
Copy Markdown
Collaborator

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlassOfWhiskey GlassOfWhiskey merged commit 6fab839 into master Mar 15, 2026
40 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the compatibility-fix branch March 15, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants