Conversation
* merged wpilib.md and wpilibintro.md * hide spectrum talk a bot more * specify reference sheet type Co-authored-by: spellingcat <70864274+spellingcat@users.noreply.github.com> * convert electronics pictures to html and add size tags * add `s to latex * fix readme wpilib link * add apriltag image * 2024 vision updates * remove obj detection link * feedback * hopefully explained multitag better --------- Co-authored-by: Lewis-Seiden <lewy@seiden.us> Co-authored-by: Lewis-Seiden <70111132+Lewis-Seiden@users.noreply.github.com>
* first draft of sim article edits * feedback * fixed latex * never mind * it's working in the vscode preview hello * i'm so sorry
Co-authored-by: Jacob Trentini <jacobtrentinidevelopment@gmail.com>
…s/Highlanders-Training into lewy-superstructure-s3
* added akit structure reference doc * tweaked mermaid graph code * more tweaks to try to get mermaid graph working * more tweaks * format please * example works? * what i care about works? * wrote reference material * Prettified Code! * pneumatics are for losers booo [updated code examples to reflect current practices, no substantive content changes] --------- Co-authored-by: Lewis-Seiden <aPotatoeWithANaginata@gmail.com> Co-authored-by: spellingcat <spellingcat@users.noreply.github.com>
* add choreo.md * add numerical optimization * update choreo article --------- Co-authored-by: Jacob Trentini <dev@jacob2.dev> Co-authored-by: spellingcat <70864274+spellingcat@users.noreply.github.com>
* editing pass on CommandBased.md * kevin pr feedback * fixed examples * fix kitbot examples\ (who wouldve thought that installing a java syntax checker would be a good idea * replace pathplanner reference to choreo reference in wpilib intro * update projects to 2025 (surely there's a better way to do this 😭) * import basic project also * update command based articles --------- Co-authored-by: Lewis-Seiden <lewy@seiden.us> Co-authored-by: spellingcat <70864274+spellingcat@users.noreply.github.com>
|
@kevinclark as per this i'm just getting all these merged before starting on other edits. most of these were already done (or really close to being done) so i was mostly just updating stuff to match what we did in 2025 |
kevinclark
left a comment
kevinclark
left a comment
There was a problem hiding this comment.
Generally looks fine. I know you're largely just merging what was already done, but if you didn't read @Lewis-Seiden 's stage three writeups, you should give them a look. Good context with your superstructure work @spellingcat .
| @@ -0,0 +1,328 @@ | |||
| # AdvantageKit Code Structure Reference | |||
There was a problem hiding this comment.
This doc is generally great, but doesn't appear to be linked to from anywhere. Seems like it should be?
There was a problem hiding this comment.
yep, that should be fixed on 2025-reorganization
| } | ||
|
|
||
| // Methods that IOImplementations will implement | ||
| public void setAngle(Rotation2d angle); |
There was a problem hiding this comment.
Just a TIL I thought you might find interesting. No action needed.
My knee jerk when I saw this was "we should probably mark that parameter as final so it's obvious to callers that we don't modify the angle as a side effect". But apparently Java doesn't actually enforce 'final' modifiers in interfaces, so an implementation doesn't have to use 'final' or avoid modifying the variable. Jeez, Java. What an awkward decision.
I did read through that (+ a couple of other teams' code from this year) prior to starting on this, and depending on how well this goes for the offseason bot/what gets changed before kickoff I'll likely do a follow up writeup of my own
😭 |
4 participants
collected together for easy final review