Conversation
kevinclark
left a comment
kevinclark
left a comment
There was a problem hiding this comment.
Couple of suggestions but nothing blocking.
Docs/1_General/1.2_BasicGit.md
Outdated
|
|
||
| While many modern cloud applications, like google docs, have some form of auto-save to the cloud, we don't necessarily want a single auto-updating version of our code. | ||
| Instead we use a tool called Git to manage different versions of our files and save them to Github, which lets us share the codebase between computers. | ||
| Because code can break very quickly in ways that might not be immediately obvious, it's good to be able to take a "snapshot" of the code at a point where it worked. |
There was a problem hiding this comment.
This is the most Athena way I could imagine this being described.
Not a problem, but you might consider that making changes can introduce breakage. This sounds like code just breaks for no reason.
| Similar to the Slack lists we use for other projects on the team, the robot software subteam uses Github Projects to manage projects and delegate tasks. | ||
| You can access the Project for each repository in its own tab at the top, and add tasks organized by the status columns. | ||
|
|
||
| Tasks that are explicitly about a specific PR should be converted to an issue and linked to that PR. |
There was a problem hiding this comment.
You might want to link to wherever they document issues integration with commit messages. The announcement is here but I can't find the doc.
There was a problem hiding this comment.
oh that's cool, i didn't know you could do that
There was a problem hiding this comment.
i do think i slightly prefer having the name of the feature/fix as the commit message since we've typically squashed prs into a single commit, but i'm also going to be stricter about using the GH project and linking stuff that way so it should hopefully be unambiguous
2 participants
No description provided.