Skip to content

Initial PR#4

Open
Advik-highlanders28 wants to merge 22 commits intomainfrom
pathingtool
Open

Initial PR#4
Advik-highlanders28 wants to merge 22 commits intomainfrom
pathingtool

Conversation

@Advik-highlanders28
Copy link
Copy Markdown

Working on POC for the new pathing tool, initial PR test.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add a launch configuration to this file to allow you to run the flutter app.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this

class CommandBlock {
int? index; // Optional
String type;
List<String> commands; // types of commands
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a list of command names? Or Command Objects?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking command names so that the JSON just has the names and then the arguments of the different commands. Then the robot side knows what the command means and how to execute it.

});

// pathing commands with points
factory CommandBlock.withPoints({
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you plan to handle cases where there are other arguments that aren't points related?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generalized for arguments

}

// If the command has points then get them
List<PointNode>? getPoints() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember, points should be treated just like any other argument. Don't write specific methods for points. You should right general methods that handle any sort of arguments.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants