Merged
Conversation
* Create method for AnalyticalModel added (AnalyticalModel_ByWindowSize) * AnalyticalModel_ByApertureByAzimuths implemented * AnalyticalModel_ByApertureConstruction create method implemented * AnalyticalModel AnalyticalModel_ByOpening create method implemented * AnalyticalModel_ByShade create method implemented * AnalyticalModel_ByShade create method implemented for shades * AnalyticalModel_ByVentilation create method added * AnalyticalModel_ByWeatherData create method implemented * Code cleaning * Code reorganization for cases creation * Bug fixes for cases creation methods * Case initial implementation * CaseSelection initial implementation * VentilationCase implemented * CaseSelection implemented for Cases * ApertureCaseSelection implemented * ApertureToPanelRatios initial implementation * Cases class implemented * Create Cases method added * WindowSizeCase updated * FilterSelection implemented * Bug fixes for Case and CaseSelection * ShadeCase renamed to FinShadeCase * ApertureCase initial implementation * ApertureCase updated * ApertureToPanelRatio updated * Update AnalyticalModel.cs * Bug fix for Create AnalyticalModel method * Code cleaning * Headers added * Test update --------- Co-authored-by: Jakub Ziolkowski <jakubziolkowski@digiproject.uk>
This reverts commit 8f25e24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue with merging
Validation
New fils are merged