Fix memory leaks in FIBBI/FIPPI caches#200
Open
texnokrates wants to merge 1 commit intoHomerReid:masterfrom
Open
Fix memory leaks in FIBBI/FIPPI caches#200texnokrates wants to merge 1 commit intoHomerReid:masterfrom
texnokrates wants to merge 1 commit intoHomerReid:masterfrom
Conversation
This might not be the most C++ way, but better than the previous state that misbehaved (methods from FIBBICache.cc could be linked from FIPPICache.cc, causing invalid reads and possibly memory corruption). (cherry picked from commit 6e29b17)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two different auxiliary classes with the same name for the FIBBI/FIPPI cache hash functions. This caused a linking mismatch and consequently memory leaks, probably also corruption of the cache.
Making the names unique fixes the problem.