Conversation
tshemsedinov
requested changes
Jul 10, 2018
Member
tshemsedinov
left a comment
tshemsedinov
left a comment
There was a problem hiding this comment.
LGTM except minor syntax issues. Also we don't use spaces in empty lines and trailing spaces at all.
|
|
||
| append(value) { | ||
| if (!list.head) { | ||
| list.head = Node(value) |
|
|
||
| append(value) { | ||
| if (!list.head) { | ||
| list.head = Node(value) |
| @@ -0,0 +1,64 @@ | |||
|
|
|||
| @@ -0,0 +1,64 @@ | |||
|
|
|||
| const Node = (value, next = null) => ({ | |||
Member
There was a problem hiding this comment.
It is not a class or prototype constructor so I'd like to use lowerCamelCase here.
| list.append(4); | ||
| list.remove(3); | ||
|
|
||
| for (item of list) { |
Member
There was a problem hiding this comment.
for (const item of list) {
|
|
||
| // Usage | ||
|
|
||
| const list = LinkedList(); |
| next, | ||
| }); | ||
|
|
||
| const LinkedList = () => { |
| @@ -0,0 +1,66 @@ | |||
|
|
|||
| } | ||
| }, | ||
|
|
||
| [Symbol.iterator]: function* () { |
Member
There was a problem hiding this comment.
Use shorter syntax for generator as a class/object method:
{
*[Symbol.iterator]() {
// code here
}
}
| } | ||
| }, | ||
|
|
||
| [Symbol.iterator]: function* () { |
Member
There was a problem hiding this comment.
Use shorter syntax for generators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.