Update fancontrol.py #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code that ran shell and parsed output Add code to read temp directly from /sys (as integer) Change temp thresholds from C to C/1000 to keep all arithmetic in int
Fan speed control functionality added
Low fan speed adjustments
Final adjustments
|
Does this implement the same idea as #4 ? Any advantages to this PR over that? |
Replace shell script and parse for temp with reading from sys
Read the core temperature from the file
josephtyler
suggested changes
Oct 27, 2020
Optimizations
Optimization fixes
Revert
Full revert
Fan speed control functionality added
Low fan speed adjustments
Final adjustments
Optimizations
Optimization fixes
Revert
Full revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fan speed control functionality added