Islands typescript fix #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option 'module' must be set to 'Node16' when option 'moduleResolution' is set to 'Node16'.
teach eslint how to parse typescript files. configuration taken directly from: https://typescript-eslint.io/getting-started/legacy-eslint-setup
copied directly from global types in @hubspot/cms-components
Signed-off-by: Josh Crites <josh@getwyz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"module"setting error in typescript configuration@hubspot/cms-components.jsxpartials to.tsxto provide working exampleNumberinstead ofparseIntbecauseparseIntdoesn't likenumberfor its first argumentHappy to make changes or break this up as requested. It's mostly fixing hurdles I've been hitting trying to set up a CMS React project using TS.