[Mozilla Branding Removal] Removing branding#57
Closed
markusTraber wants to merge 3 commits intoHubs-Foundation:masterfrom
Closed
[Mozilla Branding Removal] Removing branding#57markusTraber wants to merge 3 commits intoHubs-Foundation:masterfrom
markusTraber wants to merge 3 commits intoHubs-Foundation:masterfrom
Conversation
markusTraber
commented
Jul 9, 2024
markusTraber
commented
- For Github-Actions (.github/workflows/dialog.yml) I've changed the registry to "Hubs-Foundation", even though this account seemingly does not exist (yet?)
- Codeowners: Just referenced the org here, without referencing any team
- As for Habitat (habitat/plan.sh): I changed origin and maintainer. But it does have dependencies to Mozilla packages. Is Habitat even still relevant for us?
Exairnous
requested changes
Jul 23, 2024
Member
Exairnous
left a comment
Exairnous
left a comment
There was a problem hiding this comment.
Thanks! This is looking good.
I've left a couple inline comments and I'll check in with the rest of the governance team about the docker registry.
As for the Habitat stuff, I don't know, it seems to be included in a couple repositories, but I'm not sure if it's still being used or not. I'll ask some of the former Hubs team members about this in the Discord.
Co-authored-by: Exairnous <mythologylover75@gmail.com>
Member
|
I checked that the new URLs work. Overall, this LGTM. |
Member
|
Sorry we didn't get to this sooner. Closed in favor of #60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.