Closed
Conversation
…alog/ Why: 1. To consolidate development. 2. netcat was already in the base image 3. The `healthcheck` function was hacky and was less useful than fetching `http://dialog:7000/meta`
14 tasks
Member
Author
|
Closed, and commit incorporated in, in favor of #61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates with changes made in hubs-cloud/community-edition/services/dialog/
Why?
healthcheckfunction was hacky and was less useful than fetchinghttp://dialog:7000/metaHow to test
kubectl set image deployment/dialog dialog=dougreeder/dialog:match-ce-2026-01-23-20-03 -n hcce
kubectl rollout status deploy dialog -n hcce
Documentation of functionality
No change in functionality
Limitations
Does not do Mozilla branding removal
Alternatives considered
The commented-out code could have been left in, but there is no foreseeable reason it would ever be uncommented.
Additional details or related context
It appears to be necessary to use the same major version for both stages of docker build, and v20 is the oldest still supported.
tanfarming commited the changes in hubs-cloud