Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis pull request updates Esperanto language support by replacing the daily word list with a frequency-based set, removing a blocklist entry, rearranging the keyboard layout, refactoring source documentation, and updating UI text with improved Esperanto phrasing and new language code identifiers. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
webapp/data/languages/eo/SOURCES.md (1)
13-17: Consider keeping heading levels consistent under “Frequency data.”
## Modificationsreads as a higher-level section than### Frequency data; making it a subsection would improve doc structure.🧹 Suggested doc-structure tweak
### Frequency data -## Modifications +#### Modifications🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@webapp/data/languages/eo/SOURCES.md` around lines 13 - 17, Change the heading level for "Modifications" to match "Frequency data" by replacing the "## Modifications" line with "### Modifications" so it becomes a subsection under "### Frequency data"; update any adjacent headings if needed to keep the document hierarchy consistent (refer to the headings "Frequency data" and "Modifications" in the SOURCES.md content).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@webapp/data/languages/eo/eo_daily_words.txt`:
- Line 386: Remove the non-Esperanto and improper proper-name entries from the
Esperanto daily word list: delete "times" and the proper names "trump", "putin",
"david", and "blair" from eo_daily_words.txt; keep the validated Esperanto roots
like "labor", "sankt", and "milit" as-is. Ensure the file contains only valid
Esperanto words/roots (per ReVo) and update any tests or lookup logic that
assumed those removed entries are present.
In `@webapp/data/languages/eo/language_config.json`:
- Line 16: Replace the non-standard Esperanto clipboard term in the localization
value for the key "notification-copied": change the string from "Kopiita al
poŝo" to the standard "Kopiita al tondujo" so the UI uses the accepted term for
"clipboard" (update the value associated with "notification-copied" in the
language_config JSON).
In `@webapp/data/languages/eo/SOURCES.md`:
- Line 18: Fix the typo in the SOURCES.md entry for `eo_daily_words.txt`:
replace the word "frequest" with "frequent" in the line that reads
"`eo_daily_words.txt`: Top 999 most frequest words" so it correctly reads
"`eo_daily_words.txt`: Top 999 most frequent words"; update that exact string in
the file.
---
Nitpick comments:
In `@webapp/data/languages/eo/SOURCES.md`:
- Around line 13-17: Change the heading level for "Modifications" to match
"Frequency data" by replacing the "## Modifications" line with "###
Modifications" so it becomes a subsection under "### Frequency data"; update any
adjacent headings if needed to keep the document hierarchy consistent (refer to
the headings "Frequency data" and "Modifications" in the SOURCES.md content).
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
webapp/data/languages/eo/SOURCES.mdwebapp/data/languages/eo/eo_5words.txtwebapp/data/languages/eo/eo_5words_supplement.txtwebapp/data/languages/eo/eo_blocklist.txtwebapp/data/languages/eo/eo_daily_words.txtwebapp/data/languages/eo/eo_keyboard.jsonwebapp/data/languages/eo/language_config.json
💤 Files with no reviewable changes (1)
- webapp/data/languages/eo/eo_blocklist.txt
- Remove 10 non-Esperanto words containing x/y/w (yahoo, index, world, etc.) - Remove proper names from main and daily lists (trump, putin, david, blair, times, korea, china) - Remove 2,772 duplicate words from supplement (was identical to main list) - Remove 83 supplement words with invalid characters (x/y/w) - Fix clipboard translation: poŝo → tondujo (standard Esperanto) - Fix SOURCES.md: typo (frequest→frequent), heading hierarchy, updated counts
Hugo0
left a comment
Hugo0
left a comment
There was a problem hiding this comment.
Review: Data cleanup needed to pass CI
Great work on the ReVo-based word list! The ŜĜERTŬ keyboard and improved translations are solid. There are a few data issues causing the 5 CI test failures — all straightforward to fix:
1. Remove 10 non-Esperanto words from eo_5words.txt
These contain x, y, or w which aren't in the Esperanto alphabet:
yahoo, index, world, watch, party, royal, power, woods, emysl, young
2. Remove proper names/English words from eo_5words.txt and eo_daily_words.txt
trump, putin, david, blair, times, korea, china
(china is only in main, the other 6 are in both)
3. Deduplicate supplement
All 2,772 main words appear in the supplement — supplement should only contain words not in the main list. Also remove 83 supplement words with x/y/w. After cleanup: 4,343 supplement words.
4. Minor fixes
- language_config.json:
"Kopiita al poŝo"→"Kopiita al tondujo"(standard Esperanto for clipboard) - SOURCES.md:
frequest→frequent, fix heading hierarchy (### Frequency datais empty and orphaned — move content under it) - SOURCES.md: Update word counts to match cleaned files (2755 main, 993 daily, 4343 supplement)
After these fixes
All 17 Esperanto tests pass ✅ (946 total tests pass, 0 failures)
I've prepared these fixes on branch HaleyHalcyon/main in the upstream repo if you'd like to cherry-pick: 70821d9
|
@HaleyHalcyon awesome pr. fixed it up a bit and merged. |
2 participants
You seem to have fundamentally misunderstood Issue #102. The problem is not that just one word is wrong (webapp/data/languages/eo/eo_blocklist.txt), but that the entire dictionary is wrong!
Here are the first 20 words of the current dictionary for the Esperanto version. None of these are valid Esperanto words, as a dictionary search shows:
This pull request replaces the entire dictionary using the data I've collected and processed for my browser game Intervorto.
This pull request also replaces the on-screen keyboard with the de-facto standard ŜĜERTŬ keyboard layout (though the positions of Ĥ and Ĵ are not quite universal between users/systems in real life).
Summary by CodeRabbit
Documentation
Improvements