Conversation
|
for failed test in 3.8, seems related to: aws/aws-sam-cli#3661 edit: also see this SO post: https://stackoverflow.com/questions/72191560/importerror-cannot-import-name-soft-unicode-from-markupsafe we should consider if pinning markupsafe is desirable. |
|
for the failed test in 3.10, it's even more bizarre. Tests pass but tox returns 1. perhaps similar to : travis-ci/travis-ci#9096 ? |
It looks like the same error happens in 3.10 as well, just that tox continues on. |
|
What I was able to gather so far is that the virtual environment, which tox creates, uses Jinja2 in version 2.11.3 and MarkupSafe in version 2.1.1, which is not a compatible combination. So far I tried to tell tox to use a specific version in the virtual environment creation, but it does not seem to stick. |
|
So it seems like updating Jinja2 causes a lot more dependency problems, for example it needs a specific version of Flask. I will now try to downgrade MarkupSafe and see if this fixes it. |
|
Yes, downgrading MarkupSafe works. I will try to add a commit to this PR, not sure if I am allowed to do that in this Repo. |
|
No, I can't push to branches in this repository. |
|
I don't have admin permission unfortunately. |
|
I could fork the repository and start a PR from there, but avoiding that would be cleaner. |
|
Hi @skoehnen , I realize that I was horribly late dealing with my Github notifications, sorry :-/ Apparently you do have write access to this repository now, you are welcome to upload your fix if you still have it available :-) |
Flake8 has moved to GitHub and their GitLab repository is not accessible anymore, so the
pre-commitconfiguration for flake8 tests need to be updated.Unfortunately tests seem to break for other reasons under Python 3.8 and 3.10, and I have no time to investigate these failures.