Fixed an off-by-one error in boundX #248
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimondoodkin
added a commit
to shimondoodkin/Flotr2
that referenced
this pull request
Apr 5, 2018
cesutherland
added a commit
that referenced
this pull request
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an "off-by-one" error in the boundX function, under the selection.js file.
This means that if you have a selection area of width 800, you could never select the 800th pixel to the right. When you select the whole thing (either by code or by mouse dragging) the whole select area would be highlighted, but the selection message would read: 0px to 799px selected.