feat: support per-blog User-Agent overrides for feeds#7
Open
Sowevo wants to merge 4 commits intoHyaxia:mainfrom
Open
feat: support per-blog User-Agent overrides for feeds#7Sowevo wants to merge 4 commits intoHyaxia:mainfrom
Sowevo wants to merge 4 commits intoHyaxia:mainfrom
Conversation
Author
|
Sorry for the PR churn — I moved too fast 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--user-agentonblogwatcher add(similar to--scrape-selector)--user-agentto keep behavior simple and explicitWhy
Different sites may require different User-Agent values. Per-blog settings are clearer and avoid confusing precedence rules.
Changes
user_agentfield toBloguser_agentcolumn in DB schema (with migration viaALTER TABLE ... ADD COLUMN)blogwatcher add ... --user-agent "..."to persist per-blog UAblogwatcher blogsnow prints configured per-blog UA--user-agentflagVerification
go test ./...passesblogwatcher --helpno longer shows global--user-agent