[desktop] Add Linux packaging support#387
Draft
maxnoller wants to merge 3 commits intocodex/electron-mac-appfrom
Draft
[desktop] Add Linux packaging support#387maxnoller wants to merge 3 commits intocodex/electron-mac-appfrom
maxnoller wants to merge 3 commits intocodex/electron-mac-appfrom
Conversation
Wraps build:icon in a cross-platform node script so the Swift-based mac icon generator only runs on darwin, and falls back to the committed build/icon.* assets elsewhere. Adds electron-builder linux target (AppImage, deb), linux dist/pack scripts in the desktop workspace, and a root desktop:linux script mirroring desktop:mac.
The .icns bundle is only consumed by the mac electron-builder target. Requiring it on Linux/Windows blocks the cross-platform build unnecessarily.
…ty linux category Non-darwin build:icon now checks icon.png plus icon.icns/background.png/background@2x.png so a cross-platform `dist:mac` from a Linux host fails early in build:icon instead of deep inside appdmg. linux.category changes from Office to Utility to better reflect the AI/chat/admin UI content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #316.
What changed
build:iconindesktop/scripts/build-icon.mjs, a Node script that:swift scripts/generate-mac-icon.swift(same behavior as before).build/icon.png/build/icon.icnsassets. Errors loudly if those are missing.electron-builderlinuxtarget (AppImage,deb) withbuild/icon.pngandOfficecategory.dist:linuxandpack:linuxscripts indesktop/package.jsonmirroring the mac counterparts.desktop:linuxscript mirroringdesktop:mac.Why
PR #316 ships a macOS wrapper, but the Swift icon generator breaks
npm run build:desktopon Linux, and there's noelectron-builderLinux target wired up. This unblocks building and packaging the desktop app on Linux without changing any mac behavior.Validation
npm install→npm --prefix container install→npm run build:desktop→npm --workspace desktop run startlaunches the native Electron windows with the bundled gateway. Build succeeds without Swift installed.pack:linux/dist:linuxnot yet exercised on CI.Not included
dist:linux).