Fix Call to IPAddress.is_private() removed method.#6
Open
arouze wants to merge 1 commit intoHydrelioxGitHub:masterfrom
Open
Fix Call to IPAddress.is_private() removed method.#6arouze wants to merge 1 commit intoHydrelioxGitHub:masterfrom
arouze wants to merge 1 commit intoHydrelioxGitHub:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
Thanks for your work !
I have an issue with your package on homeassistant.
here the message when I try to access to the sensor :
It seems that the is_private() method was delete in netaddr@1.0.0.
This PR just replace the is_private method by the is_ipv4_private_use (bbox use only ipv4 right ?! ).
BTW, I'm not a python developper, sooo if you want to check / drop / update by PR it's fine !