Skip to content

DRAFT: HRN 598 (2): Scroll to Post Comment Path (keep comment component dumb)#656

Draft
thomasgwatson wants to merge 4 commits intodevfrom
HRN-598-keep-comment-component-dumb
Draft

DRAFT: HRN 598 (2): Scroll to Post Comment Path (keep comment component dumb)#656
thomasgwatson wants to merge 4 commits intodevfrom
HRN-598-keep-comment-component-dumb

Conversation

@thomasgwatson
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2023

Codecov Report

❌ Patch coverage is 9.37500% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.30%. Comparing base (259ddb2) to head (6770e71).
⚠️ Report is 241 commits behind head on dev.

Files with missing lines Patch % Lines
src/components/Comments/Comments.js 0.00% 15 Missing ⚠️
src/util/findComment.js 0.00% 10 Missing ⚠️
src/store/models/Notification.js 0.00% 2 Missing ⚠️
src/util/navigation.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #656      +/-   ##
==========================================
- Coverage   48.44%   48.30%   -0.15%     
==========================================
  Files         411      412       +1     
  Lines        7076     7097      +21     
  Branches     1945     1950       +5     
==========================================
  Hits         3428     3428              
- Misses       3648     3669      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lorenjohnson lorenjohnson changed the title DRAFT: Hrn 598 keep comment component dumb HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 7, 2023
@lorenjohnson lorenjohnson changed the title HRN 598: Scroll to Post Comment Path (keep comment component dumb) DRAFT: HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 7, 2023
@lorenjohnson lorenjohnson changed the title DRAFT: HRN 598: Scroll to Post Comment Path (keep comment component dumb) (DRAFT) HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 9, 2023
@lorenjohnson lorenjohnson changed the title (DRAFT) HRN 598: Scroll to Post Comment Path (keep comment component dumb) (DRAFT 2) HRN 598: Scroll to Post Comment Path (keep comment component dumb) Sep 9, 2023
@lorenjohnson lorenjohnson changed the title (DRAFT 2) HRN 598: Scroll to Post Comment Path (keep comment component dumb) DRAFT: HRN 598 (2): Scroll to Post Comment Path (keep comment component dumb) Jun 19, 2024
@lorenjohnson lorenjohnson marked this pull request as draft October 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant