fix(ci): bump publish workflow to Node 24 for npm 11.5+ OIDC support#48
Merged
fix(ci): bump publish workflow to Node 24 for npm 11.5+ OIDC support#48
Conversation
Trusted publishing on npmjs.com requires npm >= 11.5.1 (https://docs.npmjs.com/trusted-publishers). Node 22 in setup-node@v4 ships npm 10.x, which is rejected by the registry with a misleading E404 instead of the documented ENEEDAUTH. This silently blocked the v0.10.1 publish even after the trusted publisher was correctly configured on npmjs.com. Switching the runner to Node 24 bundles a recent enough npm out of the box, so we can keep the npm self-upgrade step removed (it was crashing with `Cannot find module 'promise-retry'`). CI-only change. No source / no version bump; v0.10.1 will be re-published from the existing tag via workflow_dispatch. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI-only hotfix. Bumps
actions/setup-nodenode-versionfrom22to24in.github/workflows/publish.ymlso the runner ships an npm CLI that supports OIDC trusted publishing.Why
npm's trusted publishing docs require:
Node 22 in
setup-node@v4ships npm 10.x, which the registry silently rejects with a misleadingE404 Not Found - PUT https://registry.npmjs.org/@i4ctime%2fq-ringinstead of the documentedENEEDAUTH. This is exactly what blocked the v0.10.1 publish (runs24920121657,24920570275,24920684561) even after the OIDC Trusted Publisher was added on npmjs.com — the provenance statement was successfully signed and uploaded to Sigstore each time, but npm's exchange endpoint refused the older client.Node 24 bundles npm 11.6.x, well above the 11.5.1 floor, so we can also keep the
npm install -g npm@lateststep removed (which had been crashing withCannot find module 'promise-retry').Scope
.github/workflows/publish.ymlFollow-up
After merge:
gh workflow run publish.yml --ref main -f ref=v0.10.1npm view @i4ctime/q-ring versionflips from0.9.8→0.10.1Test plan
Publish to npmstep (verified post-merge)npm view @i4ctime/q-ring versionsincludes0.10.1Made with Cursor