Permutive proxy #108
Draft
Permutive proxy #108
+2,812
−514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianPavilonis
force-pushed
the
feature/permutive-proxy
branch
from
751f13a to
f893468
Compare
ChristianPavilonis
changed the base branch from
main
to
feature/standardize-integrations
ChristianPavilonis
force-pushed
the
feature/permutive-proxy
branch
3 times, most recently
from
4810c6c to
9ff6eff
Compare
ChristianPavilonis
force-pushed
the
feature/permutive-proxy
branch
from
1d966f3 to
1f8f9ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not currently working
The current integration system seems to only rewrite urls.
But because permutive does a lot we proxy the whole SDK, and then load another js file to override the config.
We perhaps need a way to do more than rewrite, maybe fully find and modify html / inject script tags along with.
also the permutive integration would work with #114 without modification because there's only one tsjs script tag.