Skip to content

Send email notifications; adds more audit and error logging#64

Merged
simon-20 merged 24 commits intodevelopfrom
sk-send-email-notifications
Feb 16, 2026
Merged

Send email notifications; adds more audit and error logging#64
simon-20 merged 24 commits intodevelopfrom
sk-send-email-notifications

Conversation

@simon-20
Copy link
Contributor

@simon-20 simon-20 commented Feb 4, 2026

This PR:

Note: this PR adds several new environment variables, so the salt deployment infrastructure will need updating before this is deployed.

@simon-20 simon-20 requested a review from chrisarridge February 4, 2026 22:31
Copy link
Contributor

@chrisarridge chrisarridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @simon-20 . I think my three comments are:

  1. Should we change "IATI Registry" to something else?
  2. I was a bit confused between the org_human_readable_name and org_name in the templates, from what I could tell they are sort of synonymous in that org_name is set to the human readable name?
  3. There is one place where, when the application log is set to debug level, email details and PII will appear unencrypted in plaintext in the application log. I think we should move that to the audit log.

I'm not sure these are blockers, hence approved.

simon-20 added a commit that referenced this pull request Feb 16, 2026
This commit makes the changes requested in the review
of #64. Unifies the org_name/org_human_readable_name,
removes PII from debug log, renames Registry > RYD.
This commit makes the changes requested in the review
of #64. Unifies the org_name/org_human_readable_name,
removes PII from debug log, renames Registry > RYD.
@simon-20 simon-20 force-pushed the sk-send-email-notifications branch from 03afe8b to c522cbc Compare February 16, 2026 11:54
@chrisarridge
Copy link
Contributor

All good @simon-20

@simon-20 simon-20 merged commit 0ee8a77 into develop Feb 16, 2026
5 checks passed
@simon-20 simon-20 deleted the sk-send-email-notifications branch February 16, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants