Send email notifications; adds more audit and error logging#64
Merged
Send email notifications; adds more audit and error logging#64
Conversation
This will stop multiple FGA records between a given user and org pair being created in the database. Resolves #60.
This change allows for a stricter type checking setting in VS Code.
chrisarridge
approved these changes
Feb 12, 2026
Contributor
chrisarridge
left a comment
There was a problem hiding this comment.
This looks good @simon-20 . I think my three comments are:
- Should we change "IATI Registry" to something else?
- I was a bit confused between the
org_human_readable_nameandorg_namein the templates, from what I could tell they are sort of synonymous in thatorg_nameis set to the human readable name? - There is one place where, when the application log is set to debug level, email details and PII will appear unencrypted in plaintext in the application log. I think we should move that to the audit log.
I'm not sure these are blockers, hence approved.
simon-20
added a commit
that referenced
this pull request
Feb 16, 2026
This commit makes the changes requested in the review of #64. Unifies the org_name/org_human_readable_name, removes PII from debug log, renames Registry > RYD.
This commit makes the changes requested in the review of #64. Unifies the org_name/org_human_readable_name, removes PII from debug log, renames Registry > RYD.
03afe8b to
c522cbc
Compare
Contributor
|
All good @simon-20 |
This was referenced Feb 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
add_user_to_orgto useassert_precondition_met, and begins to unify the format of the audit and app logs/{user}/reporting-orgto stop users adding themselves to an organisation twice #60)EmailGeneratorclass for generating emails from templatescreate_reporting_orgto notify Support upon reporting org creation (resolving Send support@iatistandard.org an email when a new organisation is created in IATI Account #50)add_user_to_orgto notify org admin when someone joins an org (resolving Send the reporting org administrator an email when someone requests to join the organisation #49)Note: this PR adds several new environment variables, so the salt deployment infrastructure will need updating before this is deployed.