Conversation
Improve the error handling when authenticated requests are made with client IDs that haven't been setup in RYD so that more details are available in the logs. Resolves #48
Fixes the bug where when the dataset list is empty RYD reports there being 1 dataset in the meta/paging info. Resolves #45.
This adds a set of new test cases to cover the new
/users/{id}/reporting-orgs endpoint, which allows accessing
to a list of the user's reporting org roles by their ID.
chrisarridge
approved these changes
Feb 23, 2026
simon-20
deleted the
sk-error-handling--count-bug--user-reporting-orgs-endpoint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
/reporting-orgs/{id}/datasetswhere if an org had 0 datasets, it was reported as having 1 dataset, resvoling RYD incorrectly reports that there is one dataset for organisations that don't have any datasets. #45/users/{id}/reporting-orgsend point, resolving Add aGETendpoint/users/{uid}/reporting-orgswhich returns the reporting orgs a user is associated with #65, and unblocking User list and delete user functionality iati-account-web#81.reporting_orgs.pythat listed the (current user's) reporting orgs has been moved intosuitecrm_common.pyand generalised, and that code is now called from that same place inreporting_orgs.pyand from the new route handlerget_reporting_orgsinusers.py- the latter allows any suitably authorised user (at the moment: just superadmins) to view any user's reporting orgs, soget_reporting_orgsinusers.pycontains authorisation checks, where as the parallel method inreporting_orgs.pydoesn't because it always requests the current user's orgs, which the current user always has permission to view.