Fixup README #47
Open
Fixup README #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IATkachenko
requested changes
Sep 12, 2022
Owner
IATkachenko
left a comment
IATkachenko
left a comment
There was a problem hiding this comment.
@mthespian, thank you for contributing!
Could you have a look to my comments?
| ### on device event | ||
| 1. select `Device` in automatization trigger and use `SleepAsAndroid` device; | ||
| 1. select trigger from a list. | ||
| 2. select trigger from a list. |
Owner
There was a problem hiding this comment.
We don't need this: this is just md markup list syntax.
Author
There was a problem hiding this comment.
was following suit because previous lists in the readme are actually sequential in the source doc. I can drop it if you prefer, just seemed best to do the same thing everywhere.
Owner
There was a problem hiding this comment.
"Application configuration" section and "on device event" is using md-markup style, but "blueprint" is not.
I prefer to keep md-markup and fix blueprint in future.
| * restart **Home Assistant** | ||
| * go to **Home Assistant** `Settings` -> `Integrations` -> `Add Integration` (right bottom conner) | ||
| * type `Sleep As Android` in search field and click at integration name. [Clean browser cache if nothing found](https://github.com/IATkachenko/HA-SleepAsAndroid/issues/29). | ||
| * use browser refresh or clear browser cache to ensure new integration is populated |
Owner
There was a problem hiding this comment.
It is better to keep link to issue.
Pulling in 1.10 updates from main line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting the installation instructions based on an install using HACS frontend version 20220906112053.
Also cleaning up a few typos.