gracefully handle and warn about zero-gap between events for frequency estimate#87
Open
gracefully handle and warn about zero-gap between events for frequency estimate#87
Conversation
…y estimate Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More gracefully handle division by zero in
src/aiu_trace_analyzer/pipeline/normalize.pyand add user feedback:Changes made:
TraceWarningcalled "zero_gap_time" to track events with identical timestampsgap_time > 0before calculating frequencygap_timeis 0, the code now:self.warnings["zero_gap_time"].update()dur_freqinstead of attempting division by zeroUsers will now receive feedback about how many events had identical timestamps, helping them identify potential timestamp issues in their trace data. The warning message explains that this causes unreliable interval-based frequency calculation.