Add Liberty server.xml and auth role support for WAR/EAR bundles #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Architecture Summary
Overview
Added support for Liberty server configuration and authentication role control in WAR and EAR bundle parts by exposing two new properties through the Maven plugin configuration. This implementation covers both bundle part bindings (for separate bundle modules) and bundle-war/bundle-ear goals (for existing Java modules).
Core Changes
1. Bundle Part Bindings (
Warbundle.java,Earbundle.java)addCicsAllAuthenticatedRole(boolean, default:true)libertyAppConfigFile(File, optional)toBundlePartImpl()methods now pass these parameters toWarBundlePartandEarBundlePartconstructorsjvmserverproperty pattern2. Bundle-War and Bundle-Ear Mojos (
AbstractBundleWebAppMojo.java,BundleWarMojo.java,BundleEarMojo.java)AbstractBundleWebAppMojo- intermediate abstract class extendingAbstractBundleJavaMojo@Parameter(property = "cicsbundle.addCicsAllAuthenticatedRole", defaultValue = "true")@Parameter(property = "cicsbundle.libertyAppConfigFile")BundleWarMojoandBundleEarMojonow extendAbstractBundleWebAppMojoand set properties on bundle part bindingslibertyAppConfigFileif specified3. Integration Tests
Created 10 new integration tests:
Reactor-based tests (6):
test-reactor-war-liberty-config,test-reactor-war-auth-role,test-reactor-war-liberty-fulltest-reactor-ear-liberty-config,test-reactor-ear-auth-role,test-reactor-ear-liberty-fullsetup-test-artifactsreactor withtest-warandtest-earmodulesBundle-war/bundle-ear goal tests (4):
test-bundle-war-liberty-config,test-bundle-war-auth-roletest-bundle-ear-liberty-config,test-bundle-ear-auth-roleValidators: 10 new
PostBuild*classes using XMLUnit to verify:addCICSAllAuth,appConfigFile)4. Unit Tests
WarbundleTestandEarbundleTestwith test cases for new propertiestoBundlePartImpl()parameter passing5. Build Infrastructure Improvements
filterProperties6. Documentation
Configuration Examples
Bundle Part Configuration (separate bundle module):
Bundle-War Goal Configuration (existing WAR module):