fix: resolve Helm chart configuration validation errors #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes three configuration validation issues in the Helm chart introduced in PR IBM#1400: 1. OBSERVABILITY_EXCLUDE_PATHS: Changed from comma-separated string to JSON array format to match Pydantic List[str] type expectations - Before: "/health,/healthz,/ready,/metrics,/static/.*" - After: '["\/health", "\/healthz", "\/ready", "\/metrics", "\/static\/.*"]' - Error fixed: json.decoder.JSONDecodeError and pydantic_settings.SettingsError 2. PLUGINS_CLI_MARKUP_MODE: Set default value to "rich" instead of empty string to satisfy Pydantic Literal type validation - Before: "" - After: "rich" - Valid options: "markdown", "rich", "disabled", or None - Error fixed: pydantic_core._pydantic_core.ValidationError 3. fast-time-server version: Updated to latest stable release - Before: "0.9.0" - After: "0.8.0" These changes prevent validation errors during application startup when deploying via Helm. Signed-off-by: ppippi <wjdqlsdlsp@naver.com> Signed-off-by: ppippi-dev <wjdqlsdlsp@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR fixes three configuration validation errors in the Helm chart (
values.yaml) that prevent the application from starting when deployed via Helm. These issues were introduced in PR #1400.🔁 Reproduction Steps
values.yamlError 1: OBSERVABILITY_EXCLUDE_PATHS
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0) pydantic_settings.exceptions.SettingsError: error parsing value for field "observability_exclude_paths"
Error 2: PLUGINS_CLI_MARKUP_MODE
pydantic_core._pydantic_core.ValidationError: 1 validation error for Settings plugins_cli_markup_mode Input should be 'markdown', 'rich' or 'disabled' [type=literal_error, input_value='', input_type=str]
🐞 Root Cause
Issue 1:
OBSERVABILITY_EXCLUDE_PATHSwas set as a comma-separated string ("/health,/healthz,/ready,/metrics,/static/.*"), but the field inmcpgateway/config.py:741is defined asList[str], which requires JSON array format.Issue 2:
PLUGINS_CLI_MARKUP_MODEwas set as an empty string (""), but the field inmcpgateway/config.py:950is defined asLiteral["markdown", "rich", "disabled"] | None, which doesn't accept empty strings.Issue 3:
fast-time-serverversion was set to"0.9.0", but the latest stable release is"0.8.0".💡 Fix Description
Fix 1: OBSERVABILITY_EXCLUDE_PATHS
"/health,/healthz,/ready,/metrics,/static/.*"(comma-separated string)'["/health", "/healthz", "/ready", "/metrics", "/static/.*"]'(JSON array)Fix 2: PLUGINS_CLI_MARKUP_MODE
""(empty string)"rich"(matching the default in.env.example)Fix 3: fast-time-server version
"0.9.0""0.8.0"(latest stable release)🧪 Verification
make lintmake testmake coverageExpected Results:
📐 MCP Compliance (if relevant)
✅ Checklist
.env.example🔗 Related Issues