Open
Conversation
Member
|
👍 Makes sense, thanks. Good to merge from my point of view. |
Member
Author
|
I applied this change to the script on This suggests that it would also to output the extra info for So after adding another commit, I now see this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having taken quite a long time to run
check_annotations.pyI get a not-very-helpful message:But no other info is provided.
I'm not sure why we would ever want that behaviour?
I had to look at the script code to find out how to get more info, since the SubmissionWorkflow doesn't tell me.
I try to rerun the script with
-vflag to seeinfologging (another long time to run), but I get so much output that disappears off my terminal, and I can't scroll back to see it!!!This PR means that we always log the actual errors so we know that after first run of the script.
cc @dominikl