Bugfix for brainstorm.tools.extract #108
Open
michaelwand wants to merge 1 commit intoIDSIA:masterfrom
Open
Conversation
…the data iterator. Also reimplemented extract_and_save in terms of extract (fixes the very same bug).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix: brainstorm.tools.extract crashed when a mask was provided by the data iterator.
I also reimplemented extract_and_save in terms of extract (fixes the very same bug). But this glosses over some of the original settings in extract_and_save (e.g. chunked storage), which I believe are unimportant. Still, you may want to have a look.
I also added a test (test_tools.py) for the bug and its fix.