Skip to content

Implement scaling for import export price#16

Merged
FelixCAAuer merged 1 commit intofeature/storageAndRoRfrom
feature/scalingImpExpPrice
Oct 3, 2025
Merged

Implement scaling for import export price#16
FelixCAAuer merged 1 commit intofeature/storageAndRoRfrom
feature/scalingImpExpPrice

Conversation

@MarcoAnarmo
Copy link
Copy Markdown
Member

@MarcoAnarmo MarcoAnarmo commented Oct 3, 2025

@malacek: It seems that there is not scaling happening for pImpExpPrice; if the cost_scaling_factor is not 1 that causes wrong results.

    def scale_dPower_ImpExpProfiles(self):
        self.dPower_ImpExpProfiles["ImpExp"] *= self.power_scaling_factor
        self.dPower_ImpExpProfiles["Price"] *= self.cost_scaling_factor / self.power_scaling_factor

The second line shoudl fix that

@MarcoAnarmo MarcoAnarmo self-assigned this Oct 3, 2025
@MarcoAnarmo MarcoAnarmo added the bug Something isn't working label Oct 3, 2025
@MarcoAnarmo
Copy link
Copy Markdown
Member Author

MarcoAnarmo commented Oct 3, 2025

Proposed changes by @malacek have been implemented.

@MarcoAnarmo MarcoAnarmo closed this Oct 3, 2025
@MarcoAnarmo MarcoAnarmo deleted the feature/scalingImpExpPrice branch October 3, 2025 11:20
@MarcoAnarmo MarcoAnarmo requested a review from malacek October 3, 2025 11:20
@MarcoAnarmo MarcoAnarmo restored the feature/scalingImpExpPrice branch October 3, 2025 11:23
@MarcoAnarmo MarcoAnarmo reopened this Oct 3, 2025
Copy link
Copy Markdown

@malacek malacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@FelixCAAuer FelixCAAuer changed the base branch from main to feature/storageAndRoR October 3, 2025 15:00
Copy link
Copy Markdown
Contributor

@FelixCAAuer FelixCAAuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! :)

@FelixCAAuer
Copy link
Copy Markdown
Contributor

I've changed it to merge into StorageAndRoR so that I can directly take it into the new main :)

@FelixCAAuer FelixCAAuer merged commit c36496f into feature/storageAndRoR Oct 3, 2025
2 checks passed
@FelixCAAuer FelixCAAuer deleted the feature/scalingImpExpPrice branch October 3, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants