Implement scaling for import export price#16
Merged
FelixCAAuer merged 1 commit intofeature/storageAndRoRfrom Oct 3, 2025
Merged
Implement scaling for import export price#16FelixCAAuer merged 1 commit intofeature/storageAndRoRfrom
FelixCAAuer merged 1 commit intofeature/storageAndRoRfrom
Conversation
Member
Author
|
Proposed changes by @malacek have been implemented. |
FelixCAAuer
approved these changes
Oct 3, 2025
Contributor
FelixCAAuer
left a comment
There was a problem hiding this comment.
Looks good, thanks! :)
Contributor
|
I've changed it to merge into StorageAndRoR so that I can directly take it into the new main :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@malacek: It seems that there is not scaling happening for pImpExpPrice; if the cost_scaling_factor is not 1 that causes wrong results.
The second line shoudl fix that