Skip to content

Long-Duration Storage and RoR implementation#7

Merged
FelixCAAuer merged 15 commits intomainfrom
feature/storageAndRoR
Jul 25, 2025
Merged

Long-Duration Storage and RoR implementation#7
FelixCAAuer merged 15 commits intomainfrom
feature/storageAndRoR

Conversation

@FelixCAAuer
Copy link
Copy Markdown
Contributor

No description provided.

@FelixCAAuer FelixCAAuer requested a review from Copilot July 25, 2025 11:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements Long-Duration Storage (LDS) and Run-of-River (RoR) functionality by adding new table definitions and restructuring existing Excel data handling. The primary focus is on introducing storage capabilities with dedicated table definitions while consolidating inflow data handling.

  • Adds new table definitions for Power_Storage and Power_Inflows with comprehensive storage-related parameters
  • Consolidates RoR functionality into the broader storage framework by removing dedicated RoR handling
  • Reorganizes Excel file processing order alphabetically and updates version specifications

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_ExcelReaderWriter.py Reorders test combinations alphabetically and adds new storage/inflows test entries
changelog-LEGOExcels.md Reorganizes changelog sections alphabetically and adds entries for new table definitions
TableDefinitions.xml Adds comprehensive definitions for Data_Packages, Data_Sources, Power_Inflows, and Power_Storage tables
ExcelWriter.py Reorders writer methods alphabetically and adds new write methods for storage and inflows
ExcelReader.py Enhances version checking, adds new reader functions, and removes deprecated RoR-specific parameters
CaseStudy.py Refactors storage/inflows handling, removes RoR-specific code, and consolidates data processing logic

@FelixCAAuer FelixCAAuer merged commit f823c1e into main Jul 25, 2025
1 check passed
@FelixCAAuer FelixCAAuer deleted the feature/storageAndRoR branch July 25, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants