Long-Duration Storage and RoR implementation#7
Merged
FelixCAAuer merged 15 commits intomainfrom Jul 25, 2025
Merged
Conversation
Add SOCP as option to Network -> v0.1.2
Add comments for functions in ExcelReader
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements Long-Duration Storage (LDS) and Run-of-River (RoR) functionality by adding new table definitions and restructuring existing Excel data handling. The primary focus is on introducing storage capabilities with dedicated table definitions while consolidating inflow data handling.
- Adds new table definitions for
Power_StorageandPower_Inflowswith comprehensive storage-related parameters - Consolidates RoR functionality into the broader storage framework by removing dedicated RoR handling
- Reorganizes Excel file processing order alphabetically and updates version specifications
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_ExcelReaderWriter.py | Reorders test combinations alphabetically and adds new storage/inflows test entries |
| changelog-LEGOExcels.md | Reorganizes changelog sections alphabetically and adds entries for new table definitions |
| TableDefinitions.xml | Adds comprehensive definitions for Data_Packages, Data_Sources, Power_Inflows, and Power_Storage tables |
| ExcelWriter.py | Reorders writer methods alphabetically and adds new write methods for storage and inflows |
| ExcelReader.py | Enhances version checking, adds new reader functions, and removes deprecated RoR-specific parameters |
| CaseStudy.py | Refactors storage/inflows handling, removes RoR-specific code, and consolidates data processing logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.