-
Notifications
You must be signed in to change notification settings - Fork 0
race #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
race #6
Conversation
|
Привет! 😉 Это твой первый Pull Request! Поздравляю тебя :) |
| public class Main { | ||
| public static void main(String[] args) { | ||
| Scanner scanner = new Scanner(System.in); | ||
| int n = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
От этой переменной можно избавиться, если вынести значение в константу - private final static int CARS_AMOUNT = 3;
| velocity = scanner.nextDouble(); | ||
| scanner.nextLine(); | ||
|
|
||
| if (velocity >= 0 && velocity <= 250) break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
| String name = scanner.nextLine(); | ||
|
|
||
| double velocity; | ||
| while (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Код для считывания скорости с ввода лучше вынести в отдельную функцию - код, разделённый на небольшие функции, легче читать, поддерживать и переиспользовать
| } | ||
| } | ||
|
|
||
| class Car { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Код классов лучше выносить в отдельные файлы, чтобы не хранить весь код в одном файле
| String name; | ||
| double velocity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поля лучше пометить final, тем самым исключив возможность их модификации извне
No description provided.