Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a !mp addref <username> command that allows hosts to designate referees in multiplayer lobbies. The referee system enables designated users to execute commands on behalf of the host.
Key changes:
- Introduced
MultiplayerRefereeTrackerto manage referee state and automatically clear referees when leaving rooms - Added command parsing logic to detect
!mp addrefcommands and resolve usernames to API users - Modified message handling to allow referees to execute chat commands on behalf of the host
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| MultiplayerMatchSubScreen.cs | Implements MultiplayerRefereeTracker component to manage referee list and handle room state changes |
| OsuGame.cs | Registers the new MultiplayerRefereeTracker component in the dependency injection container |
| OnlineMetadataClient.cs | Removes implementation from UpdateActivity method (appears unrelated to referee functionality) |
| StandAloneChatDisplay.cs | Adds referee command parsing, username resolution, and message handling logic for referee commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referees can execute commands on the behalf of the host running this client. The referee list is local and ephemeral, it last only as long as the user running this client stays in the lobby and the list of referees is not preserved when passing host to another user.