add mixing of required mods and freemod to !mp mods#89
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the !mp mods command to support mixing required mods with freemod functionality. Previously, the command only supported either freemod (FM) or regular mods, but now allows combinations like FM+NF to force specific mods while enabling freemod for others.
- Refactored mod parsing logic to process each mod individually instead of treating freemod as a special case
- Added compatibility checking to remove incompatible mods from the allowed freemod list when required mods are present
- Improved mod conflict resolution by removing duplicate required mods from allowed mods list
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
!mp mods FM+NFforces NF and allows freemod (while removing SD from freemod as it isn't compatible with NF).